Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105983: add incognito mode to webbrowser module #106069

Closed
wants to merge 6 commits into from

Conversation

AmirNakhaeii
Copy link

@AmirNakhaeii AmirNakhaeii commented Jun 24, 2023

Add incognito / private mode to webbrowser module

open browser in incognito mode when in open() function new parameter is equal 3

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jun 24, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@AmirNakhaeii AmirNakhaeii changed the title Fix issue 105983 gh-105983: add incognito mode to webbrowser module Jun 25, 2023
@Eclips4
Copy link
Member

Eclips4 commented Jun 25, 2023

Duplicate of #105984
@kr-g already working on this issue, so, please, close this PR.
You can pick-up another issue, there's a lot of them =)

@AmirNakhaeii
Copy link
Author

@Eclips4
Well, what's the problem? I also tried to add this feature.

@kr-g
Copy link

kr-g commented Jun 25, 2023

good day @AmirNakhaeii,

just received your message via email.
and saw the message from @Eclips4

when you would please have a look at the history of the initial pull request #105984 and the code given there you will see that i already did the development before i have created the issue #105983 regarding the new feature. it is a bit confusing sometimes how github organize the flow of information.

anyway i saw that you added also support for edge.

thats great because i dont have microsoft windows.
i do development on linux only.
thank you.

probably best would be that you wait until my pull request is merged, and then you create an own issue regarding the enhancement and support for edge. and an extra pull request for that.

myself would prefer this approach since i can not spent time for taking part in a development where i dont have the proper OS and can not even test it.

thanks for your contribution, and understanding.

ps. do close your pull request #106069, also because you followed the naming convention and gave it the same name as mine - thats might be confusing to others -

@kr-g
Copy link

kr-g commented Jun 25, 2023

just corrected the different pull requests numbers in my former reply. sorry for the confusion.

@kr-g
Copy link

kr-g commented Jun 25, 2023

@AmirNakhaeii

probably best would be that you wait until my pull request is merged, and then you create an own issue regarding the enhancement and support for edge. and an extra pull request for that.

i dont know if it is possible to create "depening" issues in github.

but probably it might be also an idea to clone my git repo and checkout the branch https://github.com/kr-g/cpython/tree/kr-g-browser-incognito and create from this HEAD ref a new branch where you put your code for edge browser.

@kr-g
Copy link

kr-g commented Jun 25, 2023

@AmirNakhaeii

please have also a look here https://github.com/python/cpython/pull/105984/files at the test cases -> Lib/test/test_webbrowser.py

you need to create also one for Edge.
Thanks

@AmirNakhaeii
Copy link
Author

@kr-g
Thank you for your guidance. I will definitely fulfill your request. Good luck.

@AmirNakhaeii
Copy link
Author

@kr-g
I rarely visit my Gmail. That's why I didn't see your message.

@kr-g
Copy link

kr-g commented Jun 26, 2023

@AmirNakhaeii

I rarely visit my Gmail. That's why I didn't see your message.

ok fine, i try to keep that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants