Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89392: Make test_decimal discoverable #106209

Merged
merged 1 commit into from
Jun 29, 2023
Merged

gh-89392: Make test_decimal discoverable #106209

merged 1 commit into from
Jun 29, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 28, 2023 •
edited by bedevere-bot
Loading

It is very peculiar test file. It provides additional CLI interface and programming interface which accept options to control what to test what print during testing.

This PR is different from Zachary's patch for #64207. It only makes minimal changes necessary to make tests discoverable, use standard unittest methods to collect and run tests, and avoid changing the current behavior. The code of the module can be improved further, but this is out of the scope of this PR.

The two modified tests depended on the order in which the tests were ran.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 28, 2023
Closed
@serhiy-storchaka serhiy-storchaka force-pushed the test_decimal branch 2 times, most recently from 6dbb8a5 to 9e7f09a Compare June 28, 2023 17:14
zware
zware approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As you said, there's more cleanup to be done here, but splitting out just the discoverability fixes makes a lot of sense; I tried to do too much in my old attempt :)

@zware zware mentioned this pull request Jun 28, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 29, 2023
Merged
erlend-aasland
erlend-aasland approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice cleanup; thanks, Serhiy!

python -m test test_decimal -m "<regex>" -v now finally behaves as expected.

Lib/test/test_decimal.py Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit 0e24499 into python:main Jun 29, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 0e24499129f3917b199a6d46fa33eeedd2c447fc 3.12

@serhiy-storchaka serhiy-storchaka deleted the test_decimal branch June 29, 2023 09:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2023
@serhiy-storchaka @miss-islington
pythongh-89392: Make test_decimal discoverable (pythonGH-106209)
1f7fe73 
(cherry picked from commit 0e24499)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106229 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 29, 2023
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 bug and security fixes label Jun 29, 2023
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 bug and security fixes label Jun 29, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2023
@serhiy-storchaka @miss-islington
pythongh-89392: Make test_decimal discoverable (pythonGH-106209)
132a20b 
(cherry picked from commit 0e24499)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106230 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 29, 2023
@zware
Copy link
Member

zware commented Jun 29, 2023

Only took 10 years, but we got there! Thanks Serhiy :)

ambv pushed a commit that referenced this pull request Jul 5, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-89392: Make test_decimal discoverable (GH-106209) (#106230)
334b95b 
gh-89392: Make test_decimal discoverable (GH-106209)
(cherry picked from commit 0e24499)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this pull request Jul 5, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-89392: Make test_decimal discoverable (GH-106209) (#106229)
33fb895 
(cherry picked from commit 0e24499)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@zware zware zware approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @zware @erlend-aasland