Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106320: Remove _Py_SwappedOp from the C API #107036

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 22, 2023

Move _Py_SwappedOp to the internal C API (pycore_object.h).

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if someone is using this API, they can write their utility function.

@vstinner
Copy link
Member Author

lgtm, if someone is using this API, they can write their utility function.

If someone uses it, we can consider exposing a public API for that.

Or they can just copy/paste this short array in their code.

Move _Py_SwappedOp to the internal C API (pycore_object.h).
The symbol is still exported since it's part of the stable ABI.
@vstinner
Copy link
Member Author

The symbol must still be exported since it's part of the stable ABI.

@vstinner vstinner merged commit 6fbc717 into python:main Jul 22, 2023
15 checks passed
@vstinner vstinner deleted the remove_swapped_op branch July 22, 2023 16:21
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
Move _Py_SwappedOp to the internal C API (pycore_object.h).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants