Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104146: Remove dead code from Argument Clinic #107555

Merged
merged 2 commits into from
Aug 2, 2023
Merged

gh-104146: Remove dead code from Argument Clinic #107555

merged 2 commits into from
Aug 2, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 2, 2023 •
edited by bedevere-bot
Loading

Remove commented out lines from clinic.py

@erlend-aasland
pythongh-104146: Remove dead code from Argument Clinic
8c3e9fa 
Remove commented out lines from clinic.py
@bedevere-bot bedevere-bot mentioned this pull request Aug 2, 2023
Closed
@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 2, 2023 •
edited
Loading

There's an unused import of Callable in cpp.py as well, want to tackle that while we're here? :)

It doesn't feel like it deserves its own PR

AlexWaygood
AlexWaygood approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 2, 2023 08:55
@erlend-aasland erlend-aasland linked an issue Aug 2, 2023 that may be closed by this pull request
Remove dead code from clinic.py #104146
Closed
@erlend-aasland erlend-aasland merged commit 439466a into python:main Aug 2, 2023
18 checks passed
@erlend-aasland erlend-aasland deleted the clinic/remove-dead-code branch August 2, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dead code from clinic.py
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot