Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108927: Fix removing testing modules from sys.modules #108952

Merged
merged 20 commits into from
Dec 4, 2023
Merged

gh-108927: Fix removing testing modules from sys.modules #108952

merged 20 commits into from
Dec 4, 2023

Commits on Sep 5, 2023

  1. pythongh-108927: Do not remove tested modules from sys.modules 

    It breaks import machinery if the test module has submodules used in
other tests.
    @serhiy-storchaka
    serhiy-storchaka committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    339f260 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Update NEWS entry.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e52be9b View commit details
    Browse the repository at this point in the history

  2. Fix unloading the newly imported modules after testing.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    68c014e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge branch 'main' into regretest-no-remove-test-module

    @serhiy-storchaka
    serhiy-storchaka committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c1ad70c View commit details
    Browse the repository at this point in the history

  2. Add tests.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3f25ab4 View commit details
    Browse the repository at this point in the history

  3. Update Misc/NEWS.d/next/Tests/2023-09-05-20-46-35.gh-issue-108927.Tpw… 

    …Wav.rst

Co-authored-by: Brett Cannon <brett@python.org>
    @serhiy-storchaka @brettcannon
    serhiy-storchaka and brettcannon committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7673248 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Move save/unload modules down in single.py.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5df4c8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into regretest-no-remove-test-module

    @serhiy-storchaka
    serhiy-storchaka committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    eb7766b View commit details
    Browse the repository at this point in the history

  3. Refactoring.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0eae535 View commit details
    Browse the repository at this point in the history

  4. Remove also attributes from parent modules.

    @serhiy-storchaka
    serhiy-storchaka committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    66437b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Merge branch 'main' into regretest-no-remove-test-module

    @serhiy-storchaka
    serhiy-storchaka committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    8470b33 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'main' into regretest-no-remove-test-module

    @serhiy-storchaka
    serhiy-storchaka committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    544c068 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'main' into regretest-no-remove-test-module

    @serhiy-storchaka
    serhiy-storchaka committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1e7ea34 View commit details
    Browse the repository at this point in the history

  2. Only unload modules if run tests sequentially.

    @serhiy-storchaka
    serhiy-storchaka committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    56621ab View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Victor Stinner <vstinner@python.org>
    @serhiy-storchaka @vstinner
    serhiy-storchaka and vstinner committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ba5597a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge branch 'main' into regretest-no-remove-test-module

    @serhiy-storchaka
    serhiy-storchaka committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d025e22 View commit details
    Browse the repository at this point in the history

  2. Add a comment.

    @serhiy-storchaka
    serhiy-storchaka committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1aae341 View commit details
    Browse the repository at this point in the history

  3. Test that test modules are really unloaded.

    @serhiy-storchaka
    serhiy-storchaka committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    017f01d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'refs/remotes/origin/regretest-no-remove… 

    …-test-module' into regretest-no-remove-test-module
    @serhiy-storchaka
    serhiy-storchaka committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    5086405 View commit details
    Browse the repository at this point in the history

  5. Update Lib/test/test_regrtest.py 

    Co-authored-by: Victor Stinner <vstinner@python.org>
    @serhiy-storchaka @vstinner
    serhiy-storchaka and vstinner committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b3ea8fa View commit details
    Browse the repository at this point in the history