-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-109408: Move the Python file whitespace check from patchcheck to pre-commit #109891
GH-109408: Move the Python file whitespace check from patchcheck to pre-commit #109891
Conversation
AA-Turner
commented
Sep 26, 2023
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Move Azure Pipelines CI to GitHub Actions #109408
Thanks! |
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to
|
…k to pre-commit (pythonGH-109891) (cherry picked from commit 08ec4a1) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
GH-110633 is a backport of this pull request to the 3.12 branch. |
…ck to pre-commit (GH-109891) (#110633) GH-109408: Move the Python file whitespace check from patchcheck to pre-commit (GH-109891) (cherry picked from commit 08ec4a1) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@AA-Turner Please could you take care of the backports in #109890 and here? |
…tchcheck to pre-commit (pythonGH-109891) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>. (cherry picked from commit 08ec4a1) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-110641 is a backport of this pull request to the 3.11 branch. |
I've found a problem with this (and the C one) when running on macOS, pre-commit cannot find an executable called ❯ pre-commit run --all-files
Run Ruff on Lib/test/....................................................Passed
Run Ruff on Argument Clinic..............................................Passed
check toml...............................................................Passed
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
Check Python file whitespace.............................................Failed
- hook id: python-file-whitespace
- exit code: 1
Executable `python` not found
Check C file whitespace..................................................Failed
- hook id: c-file-whitespace
- exit code: 1
Executable `python` not found
Sphinx lint..............................................................Passed
Check hooks apply to the repository......................................Passed
Check for useless excludes...............................................Passed It works with Is there a portable solution? One option could be like https://github.com/pre-commit/pre-commit-hooks/blob/main/.pre-commit-hooks.yaml which has entries such as: - id: check-added-large-files
name: check for added large files
description: prevents giant files from being committed.
entry: check-added-large-files
language: python
stages: [commit, push, manual] Which uses a file like https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_added_large_files.py |
(So let's hold off on the remaining backports until this is fixed.) |
The The drawback with A |
…k to pre-commit (python#109891) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>