CI: Make macOS Intel required to succeed #110362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
added
needs backport to 3.11
|
Be careful: there is known bug on macOS: #110083 |
|
In terms of performance, the GHA macOS now seem to have good performance, between Linux and Windows:
|
Shall we wait until it's fixed? |
I didn't check the failure rate. So far, the job was non-voting (didn't block a PR if it failed). I'm tracking too many tests: https://github.com/python/cpython/issues/vstinner :-) |
|
cc @sobolevn |
|
Sorry, @hugovk and @ambv, I could not cleanly backport this to |
|
Sorry, @hugovk and @ambv, I could not cleanly backport this to |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel-based macOS aka
build_macosakax86_64-apple-darwinis Tier 1 in PEP 11, which means:mainbranch are not allowed to be merged; any breakage should be fixed or reverted immediately.main, and thus these platforms, working.Let's remove it from the "allowed to fail" list so that it is "required to succeed".
(Windows x86 (32-bit) aka
build_win32akax86_64-pc-windows-msvcis also Tier 1, but I'm not making it required in this PR because some tests are still flaky.)Also remove EOL Python 3.7 from the list of branches. (Or we probably only need bugfix and newer, 3.11+.)