-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111460: restore ncurses widechar support on macOS #111878
Conversation
Do you have the bandwidth to review this, @corona10? |
This weekend I will try :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I checked that what kinds of value $have_curses can have from source codes
Lines 6255 to 6271 in e1a1e32
AS_VAR_IF([ac_cv_header_ncurses_h], [yes], [ | |
if test "$ac_sys_system" != "Darwin"; then | |
dnl On macOS, there is no separate /usr/lib/libncursesw nor libpanelw. | |
PKG_CHECK_MODULES([CURSES], [ncursesw], [ | |
AC_DEFINE([HAVE_NCURSESW], [1]) | |
have_curses=ncursesw | |
], [ | |
WITH_SAVE_ENV([ | |
AC_CHECK_LIB([ncursesw], [initscr], [ | |
AC_DEFINE([HAVE_NCURSESW], [1]) | |
have_curses=ncursesw | |
CURSES_CFLAGS=${CURSES_CFLAGS-""} | |
CURSES_LIBS=${CURSES_LIBS-"-lncursesw"} | |
]) | |
]) | |
]) | |
fi |
Thanks for catching this.
This PR should be backported
GH-112034 is a backport of this pull request to the 3.12 branch. |
Might it be that a similar fix needs to be applied to the following line: Line 6265 in f497525
It seems to me like this check is equally broken. |
Please open a new issue for this. |
Ncurses wide character support on macOS was broken as an unintended consequence of #94452. It is now built as intended.