Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108901: Deprecate inspect.getcallargs and slate it for removal #112236

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 18, 2023

Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.


📚 Documentation preview 📚: https://cpython-previews--112236.org.readthedocs.build/

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.

@sobolevn
Copy link
Member Author

@terryjreedy thank you!

@terryjreedy
Copy link
Member

terryjreedy commented Nov 18, 2023

The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice.
EDIT: remove mistaken comment, and hide sobolevn's correct response thereto.

@sobolevn

This comment was marked as outdated.

Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing nits in the news and whatnew entries

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
Co-authored-by: Itamar Oren <itamarost@gmail.com>
Doc/library/inspect.rst Outdated Show resolved Hide resolved
Lib/inspect.py Outdated Show resolved Hide resolved
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
Lib/test/test_inspect/test_inspect.py Outdated Show resolved Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexWaygood
Copy link
Member

Ah, I see @hugovk asked for some changes in #108901 (comment) -- I'll hold off merging for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants