Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115653: Add docs for the PyCode_GetFirstFree and correct return type for the PyCode_GetNumFree #115654

Merged
merged 4 commits into from
Feb 21, 2024
Merged

gh-115653: Add docs for the PyCode_GetFirstFree and correct return type for the PyCode_GetNumFree #115654

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8559119
Add docs for public c-api function
wrongnull Feb 19, 2024
56f4c39
add missed period
wrongnull Feb 19, 2024
6619bb9
Change the wording of the function documentation
wrongnull Feb 20, 2024
2af8bee
Eleminate abbreviation and add article
wrongnull Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Doc/c-api/code.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,13 @@ bound into a function.
Return true if *co* is a :ref:`code object <code-objects>`.
This function always succeeds.

.. c:function:: int PyCode_GetNumFree(PyCodeObject *co)
.. c:function:: Py_ssize_t PyCode_GetNumFree(PyCodeObject *co)
vstinner marked this conversation as resolved.
Show resolved Hide resolved

Return the number of free variables in *co*.
Return the number of free variables in a code object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner, I think this is the suggested style:

Suggested change
Return the number of free variables in a code object.
Return the number of free variables in code object *co*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just merged the change. Is it worth it to change the style, or is it ok to merge PR gh-115752 backport? I let you decide :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not worth it to change the style, but I think we should try to keep it in mind for next time ;)


.. c:function:: int PyCode_GetFirstFree(PyCodeObject *co)

Return the position of the first free variable in a code object.
erlend-aasland marked this conversation as resolved.
Show resolved Hide resolved

.. c:function:: PyCodeObject* PyUnstable_Code_New(int argcount, int kwonlyargcount, int nlocals, int stacksize, int flags, PyObject *code, PyObject *consts, PyObject *names, PyObject *varnames, PyObject *freevars, PyObject *cellvars, PyObject *filename, PyObject *name, PyObject *qualname, int firstlineno, PyObject *linetable, PyObject *exceptiontable)

Expand Down
Loading