Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-56374: Clarify documentation of nonlocal #116942

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Mar 18, 2024

Define 'nonlocal scopes' first, and in a way that excludes class scopes.
Rearrange some of the doc. Add "Programmer's note".


📚 Documentation preview 📚: https://cpython-previews--116942.org.readthedocs.build/

Redefine 'nonlocal scopes' in a way that excludes class scopes.
Rearrange the rest of the doc.  Add "Programmer's note".
@terryjreedy terryjreedy added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Mar 18, 2024
@terryjreedy
Copy link
Member Author

The nonlocal page in doc preview looks ok.

terryjreedy and others added 2 commits March 19, 2024 13:44
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@terryjreedy terryjreedy merged commit 025ef7a into python:main Mar 19, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 19, 2024
Define 'nonlocal scopes' in a way that excludes class scopes.
Rearrange the rest of the doc.  Add "Programmer's note".
(cherry picked from commit 025ef7a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2024

GH-117023 is a backport of this pull request to the 3.12 branch.

@miss-islington-app
Copy link

Sorry, @terryjreedy, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 025ef7a5f7b424fba8713e448244b952bf897df3 3.11

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 19, 2024
@terryjreedy terryjreedy deleted the nonlocal branch March 19, 2024 17:56
@terryjreedy
Copy link
Member Author

Not worth manual backport.

terryjreedy pushed a commit that referenced this pull request Mar 19, 2024
Define 'nonlocal scopes' in a way that excludes class scopes.
Rearrange the rest of the doc.  Add "Programmer's note".

(cherry picked from commit 025ef7a)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
Define 'nonlocal scopes' in a way that excludes class scopes.
Rearrange the rest of the doc.  Add "Programmer's note".
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
Define 'nonlocal scopes' in a way that excludes class scopes.
Rearrange the rest of the doc.  Add "Programmer's note".
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Define 'nonlocal scopes' in a way that excludes class scopes.
Rearrange the rest of the doc.  Add "Programmer's note".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants