Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: announce venv creation before installing packages #117036

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Mar 19, 2024

Similar to python/devguide#1291, announce the creation of the venv before a stream of scary package installation messages appear.


📚 Documentation preview 📚: https://cpython-previews--117036.org.readthedocs.build/

@nedbat nedbat requested a review from hugovk March 19, 2024 19:45
@hugovk hugovk merged commit 332ac46 into python:main Mar 19, 2024
28 of 29 checks passed
@hugovk
Copy link
Member

hugovk commented Mar 19, 2024

Thank you!

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Mar 19, 2024
@miss-islington-app
Copy link

Thanks @nedbat for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @nedbat for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 19, 2024
)

(cherry picked from commit 332ac46)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2024

GH-117039 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 19, 2024
)

(cherry picked from commit 332ac46)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2024

GH-117040 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 19, 2024
@nedbat nedbat deleted the nedbat/venv-notice branch March 19, 2024 20:01
hugovk pushed a commit that referenced this pull request Mar 19, 2024
…7036) (#117039)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
hugovk pushed a commit that referenced this pull request Mar 19, 2024
…7036) (#117040)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants