gh-117764: Add signatures for functions in the faulthandler module #117771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Apr 11, 2024
•
serhiy-storchaka
commented
- Issue: Add more signatures for builtin functions and methods #117764
erlend-aasland
approved these changes
Apr 11, 2024
| _PyCFunction_CAST(faulthandler_unregister_py), METH_VARARGS|METH_KEYWORDS, | ||
| PyDoc_STR("unregister(signum): unregister the handler of the signal " | ||
| "'signum' registered by register()")}, | ||
| _PyCFunction_CAST(faulthandler_unregister_py), METH_VARARGS, |
There was a problem hiding this comment.
It was a bug. The function does not support keyword arguments. It was an undefined behavior.
erlend-aasland
approved these changes
Apr 12, 2024
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2024
…ule (pythonGH-117771) (cherry picked from commit 245e426) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-117806 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 12, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.