-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117804: Autoconf: silence some clang warnings for PGO builds #117796
Closed
erlend-aasland
wants to merge
5
commits into
python:main
from
erlend-aasland:autoconf/fix-pgo-warnings
Closed
gh-117804: Autoconf: silence some clang warnings for PGO builds #117796
erlend-aasland
wants to merge
5
commits into
python:main
from
erlend-aasland:autoconf/fix-pgo-warnings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* -Wno-profile-instr-unprofiled for source files without profile data * -Wno-profile-instr-out-of-date for _bootstrap_python.c
erlend-aasland
commented
Apr 12, 2024
cc @corona10 |
erlend-aasland
changed the title
gh-117752: Autoconf: silence some clang warnings for PGO builds
gh-117804: Autoconf: silence some clang warnings for PGO builds
Apr 12, 2024
corona10
approved these changes
Apr 12, 2024
Marking this as draft, since I'm not sure we should take this route. |
I agree with Steve's comments on the issue. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wno-profile-instr-unprofiled
for source files without profile data*<= solve this in a follow-up PR-Wno-profile-instr-out-of-date
for _bootstrap_python.c