Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118824: Remove deprecated master_open and slave_open from pty #118826

Merged
merged 5 commits into from
May 28, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 9, 2024

Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
sobolevn and others added 2 commits May 28, 2024 13:52
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@sobolevn sobolevn merged commit f912e5a into python:main May 28, 2024
34 of 35 checks passed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…m `pty` (python#118826)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
except ImportError:
return master_fd, slave_fd
try:
ioctl(result, I_PUSH, "ptem")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result is a NameError now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #124406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants