gh-100117: Fix inaccuracy in documentation of the CodeObject's co_positions field. #119364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…co_positions field.
iritkatriel
added
docs
markshannon
approved these changes
May 31, 2024
Doc/reference/datamodel.rst
Outdated
| Column information is 0-indexed utf-8 byte offsets on the given source | ||
| line. | ||
| position of the source code that compiled to the *i-th* code unit. A | ||
| code unit is either a bytecode instruction or a cache entry of an |
There was a problem hiding this comment.
To be pedantic, cache entries can span several code units, as can the instruction if the EXTENDED_ARG prefix is included.
Maybe just use "code unit" here, and explain the instruction format elsewhere (in another PR)
iritkatriel
commented
May 31, 2024
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2024
…co_positions field. (pythonGH-119364) (cherry picked from commit 015b1fd) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2024
…co_positions field. (pythonGH-119364) (cherry picked from commit 015b1fd) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-119869 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2024
…co_positions field. (pythonGH-119364) (cherry picked from commit 015b1fd) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-119870 is a backport of this pull request to the 3.12 branch. |
|
GH-119871 is a backport of this pull request to the 3.11 branch. |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…co_positions field. (python#119364)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…co_positions field. (python#119364)
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100117.
📚 Documentation preview 📚: https://cpython-previews--119364.org.readthedocs.build/