Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119724: Revert "bpo-45759: Better error messages for non-matching 'elif'/'else' statements (#29513)" #119974

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 3, 2024

This reverts commit 1c8f912.

3.13 Beta 2 is getting closer; IMO it'll be in a better shape with the error message change reverted.

…ching 'elif'/'else' statements (python#29513)"

This reverts commit 1c8f912.
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
@Yhg1s Yhg1s merged commit 31a4fb3 into python:main Jun 4, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @encukou for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @encukou and @Yhg1s, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 31a4fb3c74a0284436343858803b54471e2dc9c7 3.13

Yhg1s pushed a commit to Yhg1s/cpython that referenced this pull request Jun 4, 2024
…non-matching 'elif'/'else' statements (pythonGH-29513)" (pythonGH-119974)

This reverts commit 1c8f912.
(cherry picked from commit 31a4fb3)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Yhg1s pushed a commit to Yhg1s/cpython that referenced this pull request Jun 4, 2024
…non-matching 'elif'/'else' statements (pythonGH-29513)" (pythonGH-119974)

This reverts commit 1c8f912.
(cherry picked from commit 31a4fb3)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2024

GH-120013 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2024
encukou pushed a commit that referenced this pull request Jun 4, 2024
…tching 'elif'/'else' statements (GH-29513)" (GH-119974) (GH-120013)


This reverts commit 1c8f912.
(cherry picked from commit 31a4fb3)
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants