Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-120161: Fix a Crash in the _datetime Module (gh-120182) #120518

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[3.13] gh-120161: Fix a Crash in the _datetime Module (gh-120182) #120518

merged 1 commit into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. pythongh-120161: Fix a Crash in the _datetime Module (pythongh-120182) 

    In pythongh-120009 I used an atexit hook to finalize the _datetime module's static types at interpreter shutdown.  However, atexit hooks are executed very early in finalization, which is a problem in the few cases where a subclass of one of those static types is still alive until the final GC collection.  The static builtin types don't have this probably because they are finalized toward the end, after the final GC collection.  To avoid the problem for _datetime, I have applied a similar approach here.

Also, credit goes to @mgorny and @neonene for the new tests.

FYI, I would have liked to take a slightly cleaner approach with managed static types, but wanted to get a smaller fix in first for the sake of backporting.  I'll circle back to the cleaner approach with a future change on the main branch.
(cherry picked from commit b2e71ff)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
    @ericsnowcurrently @miss-islington
    ericsnowcurrently authored and miss-islington committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    56de13c View commit details
    Browse the repository at this point in the history