gh-122358: Remove re._compile #122357
Open
gh-122358: Remove re._compile #122357
+76
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wimglenn
commented
Jul 27, 2024
•
wimglenn
commented
- Issue: Refactor - remove re._compile? #122358
wimglenn
force-pushed
the
re-compile
branch
3 times, most recently
from
4e06a9c
to
e6506a6
Compare
ZeroIntensity
approved these changes
Aug 2, 2024
|
Please add a news entry. If you use the blurb CLI, please upgrade to 1.2: https://discuss.python.org/t/new-blurb-1-2-please-upgrade/59159 |
Move implementation directly into re.compile. Simplifies tracebacks and reduces call stack.
|
@hugovk Blurbed it, though there is no user-facing change here. |
|
Thanks! Also please don't force push in this repo, we squash merge everything at the end: https://devguide.python.org/getting-started/pull-request-lifecycle/#quick-guide |
AA-Turner
approved these changes
Aug 7, 2024
Misc/NEWS.d/next/Library/2024-08-04-13-22-32.gh-issue-122358.wpnaq4.rst
Outdated
Show resolved
Hide resolved
Lib/test/test_re.py
Outdated
| @@ -1227,7 +1227,7 @@ def test_pickling(self): | |||
| pickled = pickle.dumps(oldpat, proto) | |||
| newpat = pickle.loads(pickled) | |||
| self.assertEqual(newpat, oldpat) | |||
| # current pickle expects the _compile() reconstructor in re module | |||
| # previous pickles may expect the _compile() reconstructor in re module | |||
There was a problem hiding this comment.
Is it worth adding a test for pickles that expect _compile()? ("No" is a valid answer)
There was a problem hiding this comment.
I've added it in df79dd5
…pnaq4.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
There are arguments against this change. See details in my comment in the issue. |
This uses the warnings feature skip_file_prefixes added in 3.12 python#100840
|
@serhiy-storchaka ping? anything more to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.