Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121268: remove workarounds for non-IEEE 754 systems in cmath #122716

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Aug 6, 2024

as now building Python now requires support of IEEE 754 floating point numbers.

as now building Python now requires support of IEEE 754 floating point
numbers.
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 8, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 470a59d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 8, 2024
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if buildbots are happy with this change.

@skirpichev
Copy link
Member Author

No failures, related to this pr.

@vstinner vstinner merged commit b6e745a into python:main Aug 9, 2024
104 of 112 checks passed
@vstinner
Copy link
Member

vstinner commented Aug 9, 2024

Merged, thanks.

@skirpichev skirpichev deleted the drop-cmath-legacy-121268 branch August 9, 2024 09:26
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit b6e745a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1380/builds/1044) and take a look at the build logs.
  4. Check if the failure is related to this commit (b6e745a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1380/builds/1044

Failed tests:

  • test_socketserver

Failed subtests:

  • test_UnixDatagramServer - test.test_socketserver.SocketServerTest.test_UnixDatagramServer

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 222, in test_UnixDatagramServer
    self.run_server(socketserver.UnixDatagramServer,
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    socketserver.DatagramRequestHandler,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    self.dgram_examine)
                    ^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/support/threading_helper.py", line 66, in decorator
    return func(*args)
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 133, in run_server
    testfunc(svrcls.address_family, addr)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 160, in dgram_examine
    buf = data = receive(s, 100)
                 ~~~~~~~^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 43, in receive
    raise RuntimeError("timed out on %r" % (sock,))
RuntimeError: timed out on <socket.socket fd=34, family=1, type=2, proto=0, laddr=./test_python_7aihzq4p.sock>


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 240, in serve_forever
    self._handle_request_noblock()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 320, in _handle_request_noblock
    self.handle_error(request, client_address)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 318, in _handle_request_noblock
    self.process_request(request, client_address)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 349, in process_request
    self.finish_request(request, client_address)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 362, in finish_request
    self.RequestHandlerClass(request, client_address, self)
    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 763, in __init__
    self.finish()
    ~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 858, in finish
    self.socket.sendto(self.wfile.getvalue(), self.client_address)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 54] Connection reset by peer
ERROR

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…python#122716)

As now building Python now requires support of IEEE 754 floating point
numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants