gh-116622: Android test script improvements #124012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
commented
Sep 12, 2024
Comment on lines
+583
to
+585
| "-v", "--verbose", action="count", default=0, | ||
| help="Show Gradle output, and non-Python logcat messages. " | ||
| "Use twice to include high-volume messages which are rarely useful.") |
There was a problem hiding this comment.
Once this is merged, I'll switch the the buildbot over to -v mode so it will capture all non-Python log messages except the high-volume ones from test_syslog. These messages have been critical for understanding test failures in the past, including SELinux errors, low memory warnings, and signals being delivered to the wrong thread.
Since -v also displays the Gradle build log, there will no longer be any need for the buildbot to have a separate build_testbed step, hence the change to its comment above.
freakboy3742
approved these changes
Sep 13, 2024
|
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2024
* Set Android test script stdout to line-buffered * Print warning logcat messages on stderr * Add a -vv option to display high-volume messages which are rarely useful * Documentation and comment improvements (cherry picked from commit 1f9d163) Co-authored-by: Malcolm Smith <smith@chaquo.com>
|
GH-124034 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or documents various issues encountered while setting up the Android buildbot.