Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-124068: Fix reference leak with generators in the free-threaded build #124069

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Sep 13, 2024

If the generator is already cleared, then most fields in the generator's frame are not valid other than f_executable. The invalid fields may contain dangling pointers and should not be used.

…ded build

If the generator is already cleared, then most fields in the
generator's frame are not valid other than f_executable. The invalid
fields may contain dangling pointers and should not be used.
@colesbury
Copy link
Contributor Author

!buildbot NoGIL Refleaks

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 8d220b7 🤖

The command will test the builders whose names match following regular expression: NoGIL Refleaks

The builders matched are:

  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR

@colesbury colesbury marked this pull request as ready for review September 13, 2024 19:04
@Eclips4
Copy link
Member

Eclips4 commented Sep 13, 2024

I can confirm that this solves test_asyncio.test_base_events leak.
To make sure I'll run the entire test suite in hunt refleaks mode.

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zware
Copy link
Member

zware commented Sep 13, 2024

!buildbot AMD64 Windows10

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit 6bebed9 🤖

The command will test the builders whose names match following regular expression: AMD64 Windows10

The builders matched are:

  • AMD64 Windows10 PR

@zware
Copy link
Member

zware commented Sep 13, 2024

Checking this on the Windows10 buildbot on the off chance that this fixes the other failure that has been tracked to 8810e28.

(Update: nope)

@colesbury colesbury merged commit b02301f into python:main Sep 14, 2024
35 of 36 checks passed
@colesbury colesbury deleted the gh-124068-refleak branch September 14, 2024 02:02
@colesbury
Copy link
Contributor Author

The Windows10 buildbot problem is fixed in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants