[3.13] gh-124309: Modernize the staggered_race implementation to support eager task factories (GH-124390)
#124573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port eager task factories (pythonGH-124390) (cherry picked from commit de929f3) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
miss-islington
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
This was referenced Sep 26, 2024
Merged
kumaraditya303
approved these changes
Sep 26, 2024
|
Does this need to go into 3.13.0, or can it wait until 3.13.1? |
This was referenced Sep 26, 2024
would be good to have in 3.13.0 as loop param is now added back. |
gvanrossum
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
LGTM, two optional nits.
I'll leave it to @Yhg1s to decide whether to include this in RC3.
Lib/asyncio/base_events.py
Outdated
| happy_eyeballs_delay, loop=self) | ||
| happy_eyeballs_delay) |
There was a problem hiding this comment.
I added it back but I don't think it's necessary, loop would be the running loop anyways at this point.
gvanrossum
approved these changes
Sep 30, 2024
Yhg1s
reviewed
Oct 24, 2024
|
This original PR was reverted, and this backport is no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit de929f3)
Co-authored-by: Peter Bierma zintensitydev@gmail.com
Co-authored-by: Thomas Grainger tagrain@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Carol Willing carolcode@willingconsulting.com
Co-authored-by: Kumar Aditya kumaraditya@python.org