Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124787: Fix TypeAliasType and incorrect type_params #124795

Merged
merged 2 commits into from
Oct 11, 2024
Merged

gh-124787: Fix TypeAliasType and incorrect type_params #124795

merged 2 commits into from
Oct 11, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 30, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 30, 2024
Open
Daraan added a commit to Daraan/typing_extensions that referenced this pull request Sep 30, 2024
@Daraan
Consider Type Error from python/cpython/pull/124795
4e2f041
@Daraan Daraan mentioned this pull request Oct 1, 2024
Merged
3 tasks
JelleZijlstra
JelleZijlstra approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's run this through the refleak buildbots to make sure.

Misc/NEWS.d/next/Library/2024-09-30-20-46-32.gh-issue-124787.3FnJnP.rst Outdated Show resolved Hide resolved
@JelleZijlstra
Copy link
Member

!buildbot refleak

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 7d439f8 🤖

The command will test the builders whose names match following regular expression: refleak

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 Windows11 Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • aarch64 Fedora Rawhide Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR
  • AMD64 Fedora Stable Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 RHEL8 Refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 CentOS9 Refleaks PR

@sobolevn @JelleZijlstra
Update Misc/NEWS.d/next/Library/2024-09-30-20-46-32.gh-issue-124787.3…
3b3440b 
…FnJnP.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@sobolevn
Copy link
Member Author

sobolevn commented Oct 8, 2024

Refleaks are green 🎉
Снимок экрана 2024-10-08 в 13 37 51

@sobolevn
Copy link
Member Author

@JelleZijlstra what do you think: is this a bug fix or a new feature? Should we backport this to 3.12 and 3.13?

@JelleZijlstra
Copy link
Member

To me this feels too risky to backport; let's apply it to 3.14 only.

@sobolevn sobolevn merged commit 2115d76 into python:main Oct 11, 2024
37 checks passed
@Daraan Daraan mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @JelleZijlstra @bedevere-bot