-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36345: Include the code from Tools/scripts/serve.py for the wsgiref-base web server example #12562
bpo-36345: Include the code from Tools/scripts/serve.py for the wsgiref-base web server example #12562
Changes from 4 commits
756332d
74fd34c
c938813
a3dbd35
530ed32
2b1fa72
a7db659
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Avoid the duplication of code from ``Tools/scripts/serve.py`` in using the | ||
:rst:dir:`literalinclude` directive for the basic wsgiref-based web server in the | ||
documentation of :mod:`wsgiref`. Contributed by Stéphane Wirtel. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ def app(environ, respond): | |
return [b'not found'] | ||
|
||
if __name__ == '__main__': | ||
path = sys.argv[1] | ||
path = sys.argv[1] if len(sys.argv) > 1 else os.getcwd() | ||
port = int(sys.argv[2]) if len(sys.argv) > 2 else 8000 | ||
httpd = simple_server.make_server('', port, app) | ||
print("Serving {} on port {}, control-C to stop".format(path, port)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When I press CTRL+C, I get a ResourceWarning. Please add httpd.server_close() after print("\b\bShutting down."). By the way, I'm not sure that "\b" is supported on Windows. I suggest to remove ""\b\b" to make the script more portable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.