Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-37163: Deprecate passing argument obj of dataclasses.replace() by keyword. #13877

Merged
merged 1 commit into from
Jun 19, 2019
Merged

[3.8] bpo-37163: Deprecate passing argument obj of dataclasses.replace() by keyword. #13877

merged 1 commit into from
Jun 19, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 7, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 7, 2019
@serhiy-storchaka serhiy-storchaka changed the title bpo-37163: Deprecate passing argument obj of dataclasses.replace() by keyword. [3.8] bpo-37163: Deprecate passing argument obj of dataclasses.replace() by keyword. Jun 7, 2019
@pablogsal
Copy link
Member

I think you need to change the signature in the docs as well, or is that only for the 3.9 patch?

@serhiy-storchaka serhiy-storchaka merged commit f5b89af into python:3.8 Jun 19, 2019
@serhiy-storchaka serhiy-storchaka deleted the dataclasses-replace-obj-38 branch June 19, 2019 07:33
@serhiy-storchaka
Copy link
Member Author

I think that only for the 3.9 patch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 26, 2019
@serhiy-storchaka
[3.7] bpo-37163: dataclasses.replace() now supports the field named "…
7636a62 
…obj". (pythonGH-13877)

(cherry picked from commit f5b89af)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jun 26, 2019
@serhiy-storchaka
[3.7] bpo-37163: dataclasses.replace() now supports the field named "…
6ef103f 
…obj". (GH-13877) (GH-14405)

(cherry picked from commit f5b89af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @pablogsal @the-knights-who-say-ni @bedevere-bot