-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-19820: Updated documentation for inspect module: some module attributes were… #15359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
Please add an entry for __spec__
.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
@MichaelAnckaert, please address the code reviews. Thank you! |
2a23e7d
to
a69160c
Compare
I have made the requested changes; please review again |
Thanks for making the requested changes! @ericsnowcurrently: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think name
is still missing an underscore on the tail end and that is why this hasn't been merged
#15359 (comment)
a69160c
to
a1b76e5
Compare
Updated PR with requested changes. |
We're still missing |
@MichaelAnckaert Would you still interested in giving this PR a quick update? |
I'll start on a separate PR here and close this when that's open, let me know if you'd like to continue this PR. |
See #98116 |
Updated documentation for inspect module: some module attributes were missing
https://bugs.python.org/issue19820
#64019