Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-19820: Updated documentation for inspect module: some module attributes were… #15359

Closed
wants to merge 2 commits into from
Closed

bpo-19820: Updated documentation for inspect module: some module attributes were… #15359

wants to merge 2 commits into from

Conversation

MichaelAnckaert
Copy link
Contributor

@MichaelAnckaert MichaelAnckaert commented Aug 21, 2019 •
edited by JelleZijlstra
Loading

Updated documentation for inspect module: some module attributes were missing

https://bugs.python.org/issue19820

#64019

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 21, 2019
eamanu
eamanu reviewed Aug 21, 2019
View reviewed changes
Doc/library/inspect.rst Outdated Show resolved Hide resolved
epicfaace
epicfaace suggested changes Aug 23, 2019
View reviewed changes
Doc/library/inspect.rst Show resolved Hide resolved
ericsnowcurrently
ericsnowcurrently requested changes Sep 11, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

Please add an entry for __spec__.

Doc/library/inspect.rst Outdated Show resolved Hide resolved
Doc/library/inspect.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor

@MichaelAnckaert, please address the code reviews. Thank you!

@MichaelAnckaert
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

rhyn0
rhyn0 suggested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@rhyn0 rhyn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think name is still missing an underscore on the tail end and that is why this hasn't been merged
#15359 (comment)

@MichaelAnckaert
Copy link
Contributor Author

Updated PR with requested changes.

@JelleZijlstra
Copy link
Member

We're still missing __spec__ which @ericsnowcurrently asked for.

@slateny
Copy link
Contributor

slateny commented Sep 26, 2022 •
edited
Loading

@MichaelAnckaert Would you still interested in giving this PR a quick update?

@slateny
Copy link
Contributor

slateny commented Oct 2, 2022

I'll start on a separate PR here and close this when that's open, let me know if you'd like to continue this PR.

@slateny
Copy link
Contributor

slateny commented Oct 9, 2022

See #98116

@slateny slateny closed this Oct 9, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@epicfaace epicfaace epicfaace requested changes

@rhyn0 rhyn0 rhyn0 requested changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
awaiting change review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.