bpo-38144: Add the root_dir and dir_fd parameters in glob.glob(). #16075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackerySpytz
reviewed
Jun 9, 2020
| return stat.S_ISDIR(st.st_mode) | ||
|
|
||
| def _join(dirname, basename): | ||
| # It is common if dirname or basename is empty |
There was a problem hiding this comment.
I don't think this comment is necessary.
There was a problem hiding this comment.
Why not? It explains why the special case was added.
Or maybe you can suggest better wording?
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38144