doc: fix documented winmode argument default in ctypes CDLL classes. #19167
Conversation
The default value for the `winmode` argument in the ctypes CDLL, OleDll, and WinDLL classes is `None` and not `0` and these have different behaviours. `None` means ctypes default of LOAD_LIBRARY_SEARCH_DEFAULT_DIRS | LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR while `0` means no LOAD_LIBRARY_SEARCH flag which defaults to Windows `LoadLibrary` behaviour.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
The only check that this PR seems to be failing is that there's no # issue in title. I think this fix is trivial enough to receive the "skip issue" label (please correct me if I'm wrong). Can someone let me know what else is needed from me? |
Co-authored-by: Eryk Sun <eryksun@gmail.com>
The default value for the
winmodeargument in the ctypes CDLL, OleDll, and WinDLL classes isNoneand not0as currently documented. These have different behaviours.Nonemeans ctypes default ofLOAD_LIBRARY_SEARCH_DEFAULT_DIRS | LOAD_LIBRARY_SEARCH_DLL_LOAD_DIRwhile0means noLOAD_LIBRARY_SEARCH_*flag which defaults to WindowsLoadLibrarybehaviour.I did read the contribution guidelines and started to describe an issue on the Python bug tracker but this seems to me like one of those trivial changes that are described as being exempt of that. Please let me know if I'm wrong.