Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40170: Remove PyIndex_Check() macro #19375

Closed
wants to merge 1 commit into from
Closed

bpo-40170: Remove PyIndex_Check() macro #19375

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 4, 2020 •
edited by bedevere-bot
Loading

Always declare PyIndex_Check() as an opaque function to hide
implementation details: remove PyIndex_Check() macro. The macro
accessed directly PyTypeObject.tp_as_number field which prevented to
make PyTypeObject structure opaque.

https://bugs.python.org/issue40170

@vstinner
bpo-40170: Remove PyIndex_Check() macro
407b9ba 
Always declare PyIndex_Check() as an opaque function to hide
implementation details: remove PyIndex_Check() macro. The macro
accessed directly the PyTypeObject.tp_as_number member.
@vstinner
Copy link
Member Author

vstinner commented Apr 7, 2020

I created PR #19426 to prepare the work on PyIndex_Check() macro of the public C API. I will rewrite this change on top of PR #19426 once it will be merged.

@vstinner vstinner closed this Apr 7, 2020
@vstinner vstinner deleted the remove_pyindex_check_macro branch April 7, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot