bpo-18319: gettext() can retrieve a message even if a plural form exists #19869

gbassiere · 2020-05-02T22:04:01Z

Let's say you have this in your code:

gettext('egg')

and elsewhere this :

ngettext('egg', 'eggs', n)

GNU gettext tools extracts these as the same unique message and sensibly creates a pluralized entry in the PO file.

In the Python gettext module, when the MO file is parsed, a singular 'egg' will be stored as:

catalog['egg']

whereas a pluralized 'egg' is stored as:

catalog[('egg', 0)]
catalog[('eggs', 1)]

As a consequence, gettext('egg') fail to retrieve translations and you have to resort to ngettext('egg', 'eggs', 1) which is odd.

My suggestion is simply to modify gettext() so that is looks for catalog[('egg', 0)] if catalog['egg'] didn't match.

https://bugs.python.org/issue18319

… form exists

the-knights-who-say-ni · 2020-05-02T22:04:05Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@gbassiere

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

remilapeyre · 2020-06-09T22:46:32Z

Lib/gettext.py

-            return message
+            try:
+                # if `message` has plural forms
+                tmsg = self._catalog[(message, self.plural(1))]


Suggested change

tmsg = self._catalog[(message, self.plural(1))]

return self._catalog[(message, self.plural(1))]

taleinat · 2020-10-18T10:47:35Z

Lib/gettext.py

-            if self._fallback:
-                return self._fallback.gettext(message)
-            return message
+            try:


I suggest simply adding the following before the existing if tmsg is missing: ... block:

if tmsg is missing: tmsg = self._catalog.get((message, self.plural(1)), missing)

ThiefMaster · 2021-07-13T15:42:35Z

Just noticed this annoying bug as well (via babel). It's impossible to work around without starting to mess around with message contexts (and I should NOT need to add garbage to my code (and pot files) because of this), so it would be great if this fix could get merged..

akulakov · 2021-08-06T13:41:56Z

Should this logic be also added to pgettext() ?

miss-islington · 2023-07-23T09:59:33Z

Thanks @gbassiere for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2023-07-23T09:59:33Z

Thanks @gbassiere for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot · 2023-07-23T09:59:41Z

GH-107107 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2023-07-23T09:59:45Z

GH-107108 is a backport of this pull request to the 3.12 branch.

…sts (pythonGH-19869) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>

…orm exists (GH-19869) (#107108) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>

…sts (python#19869)

…orm exists (GH-19869) (GH-107107) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>

After python/cpython#19869 PR merged gettext() can lookup plural() which is not set when constructor argument (file handler) is unspecified

Issue python#18319: gettext() can retrieve a message even if a plural…

9be6e67

… form exists

the-knights-who-say-ni added the CLA not signed label May 2, 2020

bedevere-bot added the awaiting review label May 2, 2020

Add missing Misc/NEWS.d

26b8f1c

the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 4, 2020

remilapeyre approved these changes Jun 9, 2020

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Jun 9, 2020

taleinat reviewed Oct 18, 2020

View reviewed changes

jwilk mannequin mentioned this pull request Apr 10, 2022

gettext() cannot find translations with plural forms #62519

Closed

ezio-melotti removed the CLA signed label Jul 13, 2022

ambv added 2 commits July 23, 2023 10:02

Merge branch 'main' into fix-issue-18319

56e9467

Code golf

e120d70

ambv merged commit 5463252 into python:main Jul 23, 2023
17 checks passed

bedevere-bot removed the awaiting core review label Jul 23, 2023

ambv added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 23, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 23, 2023

bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 23, 2023

ambv pushed a commit that referenced this pull request Jul 23, 2023

[3.12] bpo-18319: gettext() can retrieve a message even if a plural f…

bd72fb1

…orm exists (GH-19869) (#107108) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>

jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023

bpo-18319: gettext() can retrieve a message even if a plural form exi…

433de75

…sts (python#19869)

mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023

bpo-18319: gettext() can retrieve a message even if a plural form exi…

75ca15b

…sts (python#19869)

serhiy-storchaka pushed a commit that referenced this pull request Aug 16, 2023

[3.11] bpo-18319: gettext() can retrieve a message even if a plural f…

c1c3f0b

…orm exists (GH-19869) (GH-107107) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>

m-aciek added a commit to m-aciek/attributivegettext that referenced this pull request Feb 16, 2024

Fix tests for Python 3.11+

e397ae7

After python/cpython#19869 PR merged gettext() can lookup plural() which is not set when constructor argument (file handler) is unspecified

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-18319: gettext() can retrieve a message even if a plural form exists #19869

bpo-18319: gettext() can retrieve a message even if a plural form exists #19869

gbassiere commented May 2, 2020 •

edited by bedevere-bot

Loading

the-knights-who-say-ni commented May 2, 2020

remilapeyre Jun 9, 2020

taleinat Oct 18, 2020 •

edited

Loading

ThiefMaster commented Jul 13, 2021

akulakov commented Aug 6, 2021

miss-islington commented Jul 23, 2023

miss-islington commented Jul 23, 2023

bedevere-bot commented Jul 23, 2023

bedevere-bot commented Jul 23, 2023

	tmsg = self._catalog[(message, self.plural(1))]
	return self._catalog[(message, self.plural(1))]

bpo-18319: gettext() can retrieve a message even if a plural form exists #19869

bpo-18319: gettext() can retrieve a message even if a plural form exists #19869

Conversation

gbassiere commented May 2, 2020 • edited by bedevere-bot Loading

the-knights-who-say-ni commented May 2, 2020

Recognized GitHub username

remilapeyre Jun 9, 2020

Choose a reason for hiding this comment

taleinat Oct 18, 2020 • edited Loading

Choose a reason for hiding this comment

ThiefMaster commented Jul 13, 2021

akulakov commented Aug 6, 2021

miss-islington commented Jul 23, 2023

miss-islington commented Jul 23, 2023

bedevere-bot commented Jul 23, 2023

bedevere-bot commented Jul 23, 2023

gbassiere commented May 2, 2020 •

edited by bedevere-bot

Loading

taleinat Oct 18, 2020 •

edited

Loading