bpo-40447: accept all path-like objects in compileall.compile_file #19883

FFY00 · 2020-05-03T12:55:05Z

https://bugs.python.org/issue40447

the-knights-who-say-ni · 2020-05-03T12:55:08Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@FFY00

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

isidentical

Is there a reason to not to use os.fspath for supporting all path like objects?

FFY00 · 2020-05-03T14:43:19Z

Nop, I just totally forgot about that. Good catch :D

hauntsaninja

Thanks! Probably worth adding to the tests too :-)

hauntsaninja · 2020-05-03T19:07:30Z

Lib/compileall.py

@@ -157,8 +157,8 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0,
        dfile = os.path.join(ddir, name)

    if stripdir is not None:
-        fullname_parts = fullname.split(os.path.sep)
-        stripdir_parts = stripdir.split(os.path.sep)
+        fullname_parts = os.fspath(fullname).split(os.path.sep)


This has redundancy with the logic on line 151. Not sure why that's gated by the condition on quiet, though.

Oh, yes. It is odd.

@berkerpeksag sorry for bothering, do you remember why the quiet check is there? It looks like quiet is being used across the code to provide some set some kind of failing level here. The docstring is also a bit ambiguous.

full output with False or 0, errors only with 1, no output with 2

I am not sure how to parse the behavior for 1.

Should this behavior be changed? If not, the docstring should definitely be touched up.

Anyway, I am moving the path-like object translation up there.

I also added the other path arguments.

taleinat

Thanks for this PR!

This seems like a good fix, but needs a bit more work:

ISTM that this should also fix the handling of the same parameters in compile_dir.
Tests?
Clarify the NEWS entry (see inline comment.)

Misc/NEWS.d/next/Library/2020-05-03-12-55-55.bpo-40447.oKR0Lj.rst

bedevere-bot · 2020-10-18T07:16:43Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

FFY00 · 2020-10-19T21:58:50Z

requested changes; please review again

taleinat · 2020-10-20T06:27:00Z

Thanks @FFY00, that was quick!

The NEWS entry mentions fixing compile_dir as well as compile_file, but I don't see that here yet in the code or tests?

hauntsaninja · 2020-10-20T06:38:03Z

Lib/compileall.py

@@ -152,8 +152,14 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0,
                          "in combination with stripdir or prependdir"))

    success = True
-    if quiet < 2 and isinstance(fullname, os.PathLike):
+    if isinstance(fullname, os.PathLike):


nit: os.fspath is happy to take str and bytes, so you don't need this check for fullname (for the other three, you do need something to guard against None)

You're right! The last threeos.fspath calls can simply be moved below into each of the blocks handling the three directory arguments, without the isinstance checks. The first one shouldn't need the isinstance guard at all; letting os.fspath error on invalid types seems like precisely what we want here.

Sorry for the delay! This fell off my working pool. Made the changes 😊

hauntsaninja · 2020-11-20T00:37:11Z

Lib/compileall.py

    name = os.path.basename(fullname)

    dfile = None

    if ddir is not None:
-        dfile = os.path.join(ddir, name)
+        dfile = os.path.join(os.fspath(ddir), name)


One more nit: I think the call to os.fspath is only needed on line 165 with stripdir; os.path.join is happy to take PathLike objects

Although actually neither split works when stripdir is bytes, which the documentation says it's allowed to be, since os.path.sep is a str. Same for fullname although the documentation doesn't mention that bytes is allowed there.

I made the changes, let me know if there's anything else.

FFY00 · 2021-10-26T23:52:56Z

@taleinat pushed the requested changes.

jaraco

LGTM, though I haven't reviewed in detail. Let me know if there's something in particular you'd like me to critique.

hauntsaninja

Thanks, this looks correct to me.

There's still one issue that I pointed out in #19883 (comment) , but that is separate enough that we can deal with it later.

I'm not sure whether to backport. While the code itself is "new feature" it is a feature that the docs in previous versions promise exists. We should either a) backport this change, or b) amend the docs on old branches. I lean towards a) for simplicity.

cc @JelleZijlstra

Misc/NEWS.d/next/Library/2020-05-03-12-55-55.bpo-40447.oKR0Lj.rst

JelleZijlstra

I agree with backporting since this was specifically documented to work.

miss-islington · 2022-12-23T20:19:19Z

Thanks @FFY00 for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-12-23T20:19:28Z

GH-100470 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2022-12-23T20:19:31Z

GH-100471 is a backport of this pull request to the 3.10 branch.

…ythonGH-19883) (cherry picked from commit 1ecfd1e) Co-authored-by: Filipe Laíns <lains@riseup.net> Signed-off-by: Filipe Laíns <lains@archlinux.org> Signed-off-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

…H-19883) (cherry picked from commit 1ecfd1e) Co-authored-by: Filipe Laíns <lains@riseup.net> Signed-off-by: Filipe Laíns <lains@archlinux.org> Signed-off-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

See python/cpython#19883

* Correct CVE-2020-10735 documentation (python#100306) * pythongh-94912: Added marker for non-standard coroutine function detection (python#99247) This introduces a new decorator `@inspect.markcoroutinefunction`, which, applied to a sync function, makes it appear async to `inspect.iscoroutinefunction()`. * Docs: Don't upload CI artifacts (python#100330) * pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803) Use a stack to implement os.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees. * pythongh-69929: re docs: Add more specific definition of \w (python#92015) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> * pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Christian Heimes <christian@python.org> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Fixes python#89051 * pythongh-88211: Change lower-case and upper-case to match recommendations in imaplib docs (python#99625) * pythongh-100348: Fix ref cycle in `asyncio._SelectorSocketTransport` with `_read_ready_cb` (python#100349) * pythongh-99925: Fix inconsistency in `json.dumps()` error messages (pythonGH-99926) * Clarify that every thread has its own default context in contextvars (python#99246) * pythongh-99576: Fix cookiejar file that was not truncated for some classes (pythonGH-99616) Co-authored-by: Łukasz Langa <lukasz@langa.pl> * pythongh-100188: Reduce misses in BINARY_SUBSCR_(LIST/TUPLE)_INT (python#100189) Don't specialize if the index is negative. * pythongh-99991: improve docs on str.encode and bytes.decode (python#100198) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> * pythongh-91081: Add note on WeakKeyDictionary behavior when deleting a replaced entry (python#91499) Co-authored-by: Pieter Eendebak <P.T.eendebak@tudelft.nl> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> * pythongh-85267: Improvements to inspect.signature __text_signature__ handling (python#98796) This makes a couple related changes to inspect.signature's behaviour when parsing a signature from `__text_signature__`. First, `inspect.signature` is documented as only raising ValueError or TypeError. However, in some cases, we could raise RuntimeError. This PR changes that, thereby fixing python#83685. (Note that the new ValueErrors in RewriteSymbolics are caught and then reraised with a message) Second, `inspect.signature` could randomly drop parameters that it didn't understand (corresponding to `return None` in the `p` function). This is the core issue in python#85267. I think this is very surprising behaviour and it seems better to fail outright. Third, adding this new failure broke a couple tests. To fix them (and to e.g. allow `inspect.signature(select.epoll.register)` as in python#85267), I add constant folding of a couple binary operations to RewriteSymbolics. (There's some discussion of making signature expression evaluation arbitrary powerful in python#68155. I think that's out of scope. The additional constant folding here is pretty straightforward, useful, and not much of a slippery slope) Fourth, while python#85267 is incorrect about the cause of the issue, it turns out if you had consecutive newlines in __text_signature__, you'd get `tokenize.TokenError`. Finally, the `if name is invalid:` code path was dead, since `parse_name` never returned `invalid`. * pythonGH-100363: Speed up `asyncio.get_running_loop` (python#100364) * pythonGH-100133: fix `asyncio` subprocess losing `stderr` and `stdout` output (python#100154) * pythongh-100374: Fixed a bug in socket.getfqdn() (pythongh-100375) * pythongh-100129: Add tests for pickling all builtin types and functions (pythonGH-100142) * Remove unused variable from `dis._find_imports` (python#100396) * pythongh-78878: Fix crash when creating an instance of `_ctypes.CField` (python#14837) * pythonGH-69564: Clarify use of octal format of mode argument in help(os.chmod) (python#20621) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> * pythonGH-99554: Pack location tables more effectively (pythonGH-99556) * Correct typo in typing.py (python#100423) In the docstring of `ParamSpec`, the name of `P = ParamSpec('P')` was mistakenly written as `'T'`. * pythongh-99761: Add `_PyLong_IsPositiveSingleDigit` function to check for single digit integers (python#100064) * pythonGH-99770: Make the correct call specialization fail kind show up in the stats (pythonGH-99771) * pythongh-78997: fix bad rebase of moved test file (python#100424) * pythongh-100344: Add C implementation for `asyncio.current_task` (python#100345) Co-authored-by: pranavtbhat * pythonGH-99554: Trim trailing whitespace (pythonGH-100435) Automerge-Triggered-By: GH:brandtbucher * pythongh-85432: Harmonise parameter names between C and pure-Python implementations of `datetime.time.strftime`, `datetime.datetime.fromtimestamp` (python#99993) * pythongh-57762: fix misleading tkinter.Tk docstring (python#98837) Mentioned as a desired change by terryjreedy on the corresponding issue, since Tk is not a subclass of Toplevel. * pythongh-48496: Added example and link to faq for UnboundLocalError in reference (python#93068) * Fix typo in 3.12 What's New (python#100449) * pythongh-76963: PEP3118 itemsize of an empty ctypes array should not be 0 (pythonGH-5576) The itemsize returned in a memoryview of a ctypes array is now computed from the item type, instead of dividing the total size by the length and assuming that the length is not zero. * pythonGH-100459: fix copy-paste errors in specialization stats (pythonGH-100460) * pythongh-99110: Initialize `frame->previous` in init_frame to fix segmentation fault when accessing `frame.f_back` (python#100182) * pythongh-98712: Clarify "readonly bytes-like object" semantics in C arg-parsing docs (python#98710) * pythongh-92216: improve performance of `hasattr` for type objects (pythonGH-99979) * pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289) * Revert "pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289)" (python#100468) This reverts commit c3c7848. * pythongh-94155: Reduce hash collisions for code objects (python#100183) * Uses a better hashing algorithm to get better dispersion and remove commutativity. * Incorporates `co_firstlineno`, `Py_SIZE(co)`, and bytecode instructions. * This is now the entire set of criteria used in `code_richcompare`, except for `_PyCode_ConstantKey` (which would incorporate the types of `co_consts` rather than just their values). * pythongh-83076: 3.8x speed improvement in (Async)Mock instantiation (python#100252) * pythongh-99482: remove `jython` compatibility parts from stdlib and tests (python#99484) * bpo-40447: accept all path-like objects in compileall.compile_file (python#19883) Signed-off-by: Filipe Laíns <lains@archlinux.org> Signed-off-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * pythonGH-100425: Improve accuracy of builtin sum() for float inputs (pythonGH-100426) * pythongh-68320, pythongh-88302 - Allow for private `pathlib.Path` subclassing (pythonGH-31691) Users may wish to define subclasses of `pathlib.Path` to add or modify existing methods. Before this change, attempting to instantiate a subclass raised an exception like: AttributeError: type object 'PPath' has no attribute '_flavour' Previously the `_flavour` attribute was assigned as follows: PurePath._flavour = xxx not set!! xxx PurePosixPath._flavour = _PosixFlavour() PureWindowsPath._flavour = _WindowsFlavour() This change replaces it with a `_pathmod` attribute, set as follows: PurePath._pathmod = os.path PurePosixPath._pathmod = posixpath PureWindowsPath._pathmod = ntpath Functionality from `_PosixFlavour` and `_WindowsFlavour` is moved into `PurePath` as underscored-prefixed classmethods. Flavours are removed. Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Eryk Sun <eryksun@gmail.com> * pythongh-99947: Ensure unreported errors are chained for SystemError during import (pythonGH-99946) * Add "strict" to dotproduct(). Add docstring. Factor-out common code. (pythonGH-100480) * pythongh-94808: improve test coverage of number formatting (python#99472) * pythongh-100454: Start running SSL tests with OpenSSL 3.1.0-beta1 (python#100456) * pythongh-100268: Add is_integer method to int (python#100439) This improves the lives of type annotation users of `float` - which type checkers implicitly treat as `int|float` because that is what most code actually wants. Before this change a `.is_integer()` method could not be assumed to exist on things annotated as `: float` due to the method not existing on both types. * pythongh-77771: Add enterabs example in sched (python#92716) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871) Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> * pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871) Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> * Misc Itertools recipe tweaks (pythonGH-100493) * pythongh-100357: Convert several functions in `bltinsmodule` to AC (python#100358) * Remove wrong comment about `repr` in `test_unicode` (python#100495) * pythongh-99908: Tutorial: Modernize the 'data-record class' example (python#100499) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * pythongh-100474: Fix handling of dirs named index.html in http.server (pythonGH-100475) If you had a directory called index.html or index.htm within a directory, it would cause http.server to return a 404 Not Found error instead of the directory listing. This came about due to not checking that the index was a regular file. I have also added a test case for this situation. Automerge-Triggered-By: GH:merwok * pythongh-100287: Fix unittest.mock.seal with AsyncMock (python#100496) * pythongh-99535: Add test for inheritance of annotations and update documentation (python#99990) * pythongh-100428: Make float documentation more accurate (python#100437) Previously, the grammar did not accept `float("10")`. Also implement mdickinson's suggestion of removing the indirection. * [Minor PR] Quotes in documentation changed into code blocks (python#99536) Minor formatting fix in documentation Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * pythongh-100472: Fix docs claim that compileall parameters could be bytes (python#100473) * pythongh-100519: simplification to `eff_request_host` in cookiejar.py (python#99588) `IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here. The simplified implementation more clearly matches the wording in RFC 2965. Co-authored-by: hauntsaninja <hauntsaninja@gmail.com> * pythongh-99308: Clarify re docs for byte pattern group names (python#99311) * pythongh-92446: Improve argparse choices docs; revert bad change to lzma docs (python#94627) Based on the definition of the collections.abc classes, it is more accurate to use "sequence" instead of "container" when describing argparse choices. A previous attempt at fixing this in python#92450 was mistaken; this PR reverts that change. Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * Fix name of removed `inspect.Signature.from_builtin` method in 3.11.0a2 changelog (python#100525) * pythongh-100520: Fix `rst` markup in `configparser` docstrings (python#100524) * pythongh-99509: Add `__class_getitem__` to `multiprocessing.queues.Queue` (python#99511) * pythongh-94603: micro optimize list.pop (pythongh-94604) * Remove `NoneType` redefinition from `clinic.py` (python#100551) * pythongh-100553: Improve accuracy of sqlite3.Row iter test (python#100555) * pythonGH-98831: Modernize a ton of simpler instructions (python#100545) * load_const and load_fast aren't families for now * Don't decref unmoved names * Modernize GET_ANEXT * Modernize GET_AWAITABLE * Modernize ASYNC_GEN_WRAP * Modernize YIELD_VALUE * Modernize POP_EXCEPT (in more than one way) * Modernize PREP_RERAISE_STAR * Modernize LOAD_ASSERTION_ERROR * Modernize LOAD_BUILD_CLASS * Modernize STORE_NAME * Modernize LOAD_NAME * Modernize LOAD_CLASSDEREF * Modernize LOAD_DEREF * Modernize STORE_DEREF * Modernize COPY_FREE_VARS (mark it as done) * Modernize LIST_TO_TUPLE * Modernize LIST_EXTEND * Modernize SET_UPDATE * Modernize SETUP_ANNOTATIONS * Modernize DICT_UPDATE * Modernize DICT_MERGE * Modernize MAP_ADD * Modernize IS_OP * Modernize CONTAINS_OP * Modernize CHECK_EXC_MATCH * Modernize IMPORT_NAME * Modernize IMPORT_STAR * Modernize IMPORT_FROM * Modernize JUMP_FORWARD (mark it as done) * Modernize JUMP_BACKWARD (mark it as done) Signed-off-by: Filipe Laíns <lains@archlinux.org> Signed-off-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Jeremy Paige <ucodery@gmail.com> Co-authored-by: Carlton Gibson <carlton@noumenal.es> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Jon Burdo <jon@jonburdo.com> Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: Brad Wolfe <brad.wolfe@gmail.com> Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com> Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com> Co-authored-by: Bisola Olasehinde <horlasehinde@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Pieter Eendebak <P.T.eendebak@tudelft.nl> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: Dominic Socular <BBH@awsl.rip> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com> Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com> Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com> Co-authored-by: david-why <david_why@outlook.com> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: penguin_wwy <940375606@qq.com> Co-authored-by: Eli Schwartz <eschwartz93@gmail.com> Co-authored-by: Itamar Ostricher <itamarost@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Bill Fisher <william.w.fisher@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Ken Jin <kenjin@python.org> Co-authored-by: Carl Meyer <carl@oddbird.net> Co-authored-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Eryk Sun <eryksun@gmail.com> Co-authored-by: Sebastian Berg <sebastianb@nvidia.com> Co-authored-by: Illia Volochii <illia.volochii@gmail.com> Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Co-authored-by: James Frost <git@frost.cx> Co-authored-by: MonadChains <monadchains@gmail.com> Co-authored-by: Bart Broere <mail@bartbroere.eu> Co-authored-by: Glyph <code@glyph.im> Co-authored-by: hauntsaninja <hauntsaninja@gmail.com> Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com> Co-authored-by: Guy Yagev <yourlefthandman8@gmail.com> Co-authored-by: Jakub Kuczys <me@jacken.men>

See python/cpython#19883

the-knights-who-say-ni added the CLA not signed label May 3, 2020

bedevere-bot added the awaiting review label May 3, 2020

FFY00 force-pushed the bpo-40447 branch from 8ec7bcf to ac3f9c1 Compare May 3, 2020 12:56

FFY00 changed the title ~~bpo-40447: accept pathlib.path in compileall.compile_file~~ bpo-40447: accept pathlib.Path in compileall.compile_file May 3, 2020

FFY00 force-pushed the bpo-40447 branch 2 times, most recently from 99f62ad to 453d882 Compare May 3, 2020 12:59

isidentical reviewed May 3, 2020

View reviewed changes

FFY00 force-pushed the bpo-40447 branch 2 times, most recently from 924a7fd to 7b48ce8 Compare May 3, 2020 14:45

FFY00 changed the title ~~bpo-40447: accept pathlib.Path in compileall.compile_file~~ bpo-40447: accept all path-like objects in compileall.compile_file May 3, 2020

FFY00 force-pushed the bpo-40447 branch 2 times, most recently from 4a1312b to 6cafeac Compare May 3, 2020 14:46

hauntsaninja reviewed May 3, 2020

View reviewed changes

FFY00 force-pushed the bpo-40447 branch from 6cafeac to 5096432 Compare May 3, 2020 19:46

the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 4, 2020

taleinat requested changes Oct 18, 2020

View reviewed changes

Misc/NEWS.d/next/Library/2020-05-03-12-55-55.bpo-40447.oKR0Lj.rst Outdated Show resolved Hide resolved

bedevere-bot added awaiting changes and removed awaiting review labels Oct 18, 2020

FFY00 force-pushed the bpo-40447 branch 2 times, most recently from d63b4e5 to 31251fb Compare October 19, 2020 21:58

hauntsaninja reviewed Oct 20, 2020

View reviewed changes

FFY00 force-pushed the bpo-40447 branch 2 times, most recently from a6a1788 to 599bfd9 Compare November 20, 2020 00:04

hauntsaninja reviewed Nov 20, 2020

View reviewed changes

jaraco approved these changes Nov 27, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Nov 27, 2021

hauntsaninja mentioned this pull request Jun 21, 2022

compile_file's stripdir does not accept pathlib.Path #84627

Closed

ezio-melotti removed the CLA signed label Jul 13, 2022

Merge branch 'main' into bpo-40447

3dba07d

hauntsaninja approved these changes Dec 23, 2022

View reviewed changes

Merge branch 'main' into bpo-40447

0426944

hauntsaninja reviewed Dec 23, 2022

View reviewed changes

Misc/NEWS.d/next/Library/2020-05-03-12-55-55.bpo-40447.oKR0Lj.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2020-05-03-12-55-55.bpo-40447.oKR0Lj.rst

5d56bba

JelleZijlstra approved these changes Dec 23, 2022

View reviewed changes

hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 23, 2022

hauntsaninja merged commit 1ecfd1e into python:main Dec 23, 2022

bedevere-bot removed the awaiting merge label Dec 23, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 23, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 23, 2022

hauntsaninja added a commit to hauntsaninja/typeshed that referenced this pull request Dec 23, 2022

Update compileall stripdir type

1aa4978

See python/cpython#19883

hauntsaninja added a commit to hauntsaninja/typeshed that referenced this pull request Dec 23, 2022

Update compileall stripdir type

1b59042

See python/cpython#19883

hauntsaninja mentioned this pull request Dec 23, 2022

Update compileall stripdir type python/typeshed#9404

Merged

hauntsaninja added a commit to python/typeshed that referenced this pull request Jan 9, 2023

Update compileall stripdir type (#9404)

fa204f6

See python/cpython#19883

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-40447: accept all path-like objects in compileall.compile_file #19883

bpo-40447: accept all path-like objects in compileall.compile_file #19883

FFY00 commented May 3, 2020 •

edited by bedevere-bot

Loading

the-knights-who-say-ni commented May 3, 2020

isidentical left a comment

FFY00 commented May 3, 2020

hauntsaninja left a comment

hauntsaninja May 3, 2020 •

edited

Loading

FFY00 May 3, 2020

FFY00 May 3, 2020

FFY00 May 3, 2020

taleinat left a comment

bedevere-bot commented Oct 18, 2020

FFY00 commented Oct 19, 2020

taleinat commented Oct 20, 2020

hauntsaninja Oct 20, 2020 •

edited

Loading

taleinat Oct 20, 2020 •

edited

Loading

FFY00 Nov 20, 2020

hauntsaninja Nov 20, 2020

hauntsaninja Nov 20, 2020 •

edited

Loading

FFY00 Nov 29, 2020

FFY00 commented Oct 26, 2021

jaraco left a comment

hauntsaninja left a comment

JelleZijlstra left a comment

miss-islington commented Dec 23, 2022

bedevere-bot commented Dec 23, 2022

bedevere-bot commented Dec 23, 2022

bpo-40447: accept all path-like objects in compileall.compile_file #19883

bpo-40447: accept all path-like objects in compileall.compile_file #19883

Conversation

FFY00 commented May 3, 2020 • edited by bedevere-bot Loading

the-knights-who-say-ni commented May 3, 2020

CLA Missing

isidentical left a comment

Choose a reason for hiding this comment

FFY00 commented May 3, 2020

hauntsaninja left a comment

Choose a reason for hiding this comment

hauntsaninja May 3, 2020 • edited Loading

Choose a reason for hiding this comment

FFY00 May 3, 2020

Choose a reason for hiding this comment

FFY00 May 3, 2020

Choose a reason for hiding this comment

FFY00 May 3, 2020

Choose a reason for hiding this comment

taleinat left a comment

Choose a reason for hiding this comment

bedevere-bot commented Oct 18, 2020

FFY00 commented Oct 19, 2020

taleinat commented Oct 20, 2020

hauntsaninja Oct 20, 2020 • edited Loading

Choose a reason for hiding this comment

taleinat Oct 20, 2020 • edited Loading

Choose a reason for hiding this comment

FFY00 Nov 20, 2020

Choose a reason for hiding this comment

hauntsaninja Nov 20, 2020

Choose a reason for hiding this comment

hauntsaninja Nov 20, 2020 • edited Loading

Choose a reason for hiding this comment

FFY00 Nov 29, 2020

Choose a reason for hiding this comment

FFY00 commented Oct 26, 2021

jaraco left a comment

Choose a reason for hiding this comment

hauntsaninja left a comment

Choose a reason for hiding this comment

JelleZijlstra left a comment

Choose a reason for hiding this comment

miss-islington commented Dec 23, 2022

bedevere-bot commented Dec 23, 2022

bedevere-bot commented Dec 23, 2022

FFY00 commented May 3, 2020 •

edited by bedevere-bot

Loading

hauntsaninja May 3, 2020 •

edited

Loading

hauntsaninja Oct 20, 2020 •

edited

Loading

taleinat Oct 20, 2020 •

edited

Loading

hauntsaninja Nov 20, 2020 •

edited

Loading