bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows. #20035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining non-BMP characters on Windows.
vstinner
reviewed
May 11, 2020
Objects/unicodeobject.c
Outdated
| @@ -12373,6 +12373,12 @@ static PyObject * | |||
| unicode_isidentifier_impl(PyObject *self) | |||
| /*[clinic end generated code: output=fe585a9666572905 input=2d807a104f21c0c5]*/ | |||
| { | |||
| /* Since there is no way to return an error from PyUnicode_IsIdentifier() | |||
| we have to call PyUnicode_READY() to ensure that the string object is | |||
| in the "canonical" representation. */ | |||
There was a problem hiding this comment.
I don't think that this comment is worth it. It's something usual to report an error when a function fails. All functions in this file does that. I suggest to remove the comment.
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40596