Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) #23142

Merged
merged 24 commits into from
Apr 23, 2021
Merged

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) #23142

merged 24 commits into from
Apr 23, 2021

Conversation

frenzymadness
Copy link
Contributor

@frenzymadness frenzymadness commented Nov 4, 2020 •
edited by bedevere-bot
Loading

This change:

  • merges distutils.sysconfig into sysconfig while keeping the original functionality and
  • marks distutils.sysconfig as deprecated

Commits basically describe my progress step by step. Some discussions already happened in my private PR.

PEP 632 is still a draft so I'm opening this PR the same. PEP proposal and discussion.

https://bugs.python.org/issue41282

@frenzymadness frenzymadness mentioned this pull request Nov 4, 2020
Closed
@frenzymadness frenzymadness marked this pull request as draft November 4, 2020 11:31
merwok
merwok reviewed Nov 4, 2020
View reviewed changes
Lib/sysconfig.py Outdated Show resolved Hide resolved
merwok
merwok reviewed Nov 4, 2020
View reviewed changes
Lib/sysconfig.py Outdated Show resolved Hide resolved
@zooba zooba self-assigned this Nov 4, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@merwok merwok removed the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@frenzymadness
Copy link
Contributor Author

This PR is waiting for a final decision about the PEP.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@merwok merwok removed awaiting review stale Stale PR or inactive for long period of time. labels Jan 16, 2021
@pradyunsg
Copy link
Member

The PEP is accepted now.

merwok
merwok reviewed Jan 23, 2021
View reviewed changes
Doc/distutils/apiref.rst Outdated Show resolved Hide resolved
@frenzymadness frenzymadness changed the title PEP 632: Deprecate distutils.sysconfig (partial implementation of the PEP) bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) Feb 9, 2021
@frenzymadness
Copy link
Contributor Author

The pep is accepted so this PR is no longer a draft. Also, a note about the deprecation already exists here so I think it's enough to mention it once.

@frenzymadness frenzymadness marked this pull request as ready for review February 9, 2021 12:38
@encukou
Copy link
Member

encukou commented Feb 12, 2021

Can you add a NEWS entry?
(The blurb tool is packaged in Fedora, FWIW.)

@frenzymadness
Copy link
Contributor Author

News entry added.

@zooba
Copy link
Member

zooba commented Feb 15, 2021

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

@frenzymadness
Copy link
Contributor Author

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

Thank you! AFAIK the next alpha should be released tomorrow. Will we include this in it?

@frenzymadness
Copy link
Contributor Author

I've rebased the commits and fixed a conflict. The failing test is not related to this change.

Could you please merge this?

@frenzymadness
Copy link
Contributor Author

@encukou see the last commit and PTAL.

@pradyunsg
Copy link
Member

And... Could someone also relabel this, to remove the "DO-NOT-MERGE" label here? :)

merwok
merwok reviewed Apr 16, 2021
View reviewed changes
Doc/distutils/apiref.rst Outdated Show resolved Hide resolved
@frenzymadness @merwok
Update Doc/distutils/apiref.rst
cd8e387 
Co-authored-by: Éric Araujo <merwok@netwok.org>
@frenzymadness
Copy link
Contributor Author

@zooba could you please take a look at this PR? The time of the first beta release is approaching.

@encukou
Copy link
Member

encukou commented Apr 23, 2021

The patch looks good to me, it was seen by many people and I see no objections. I'll merge and watch the buildbots.

@encukou encukou merged commit 90d02e5 into python:master Apr 23, 2021
@frenzymadness frenzymadness deleted the distutils_sysconfig branch April 26, 2021 08:00
@hroncok
Copy link
Contributor

hroncok commented Jun 8, 2021

I think there is a regression in distutils.sysconfig.parse_makefile() caused by this change.

https://bugs.python.org/issue44351

@frenzymadness frenzymadness mentioned this pull request Jun 10, 2021
Merged
This was referenced Dec 21, 2021
Closed
Closed
@jaraco jaraco mentioned this pull request May 9, 2022
Closed
@jkloth jkloth mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@merwok merwok merwok left review comments

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@frenzymadness @pradyunsg @encukou @zooba @hroncok @merwok @the-knights-who-say-ni @bedevere-bot