Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reStructuredText syntax in NEWS.d. #23800

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Fix reStructuredText syntax in NEWS.d. #23800

merged 1 commit into from
Dec 16, 2020

Conversation

JulienPalard
Copy link
Member

Without this "separator", the reStructuredText parser gets it wrong.

@JulienPalard JulienPalard mentioned this pull request Dec 16, 2020
Merged
Fidget-Spinner
Fidget-Spinner approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry I wrote this news item. Thanks for fixing this! I couldn't understand why the GitHub rst highlighting was showing up like that, but now I do. Forgot that inline markup needs escaped whitespace :). Guess I need more rst practice.

@JulienPalard
Copy link
Member Author

@Fidget-Spinner no worries :) A slow CI check was finding those errors, but with false positives. I'm in the process of removing/replacing it, see #23802

@JulienPalard JulienPalard merged commit 37caeb1 into python:master Dec 16, 2020
@JulienPalard JulienPalard deleted the fix-new branch December 16, 2020 15:22
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@JulienPalard @adorilson
Fix reStructuredText typo in NEWS.d. (pythonGH-23800)
d169dcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulienPalard @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot