Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-74895: getaddrinfo no longer raises OverflowError #2435

Merged
merged 9 commits into from
Feb 14, 2023
Merged

gh-74895: getaddrinfo no longer raises OverflowError #2435

merged 9 commits into from
Feb 14, 2023

Commits on Jun 27, 2017

  1. bpo-30710: getaddrinfo does not raise OverflowError 

    Convert a numeric port number to a string without an intermediate C long.
This prevents raising OverflowError if the port number is out of the
C long range.
    @smejkar
    smejkar committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    fe317a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Merge branch 'main' into bpo-30710

    @arhadthedev
    arhadthedev committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    06de3c3 View commit details
    Browse the repository at this point in the history

  2. Add a news entry

    @arhadthedev
    arhadthedev committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    874cb15 View commit details
    Browse the repository at this point in the history

  3. Clean up after an incorrect merge

    @arhadthedev
    arhadthedev committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2175a89 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into bpo-30710

    @gpshead
    gpshead authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    399c274 View commit details
    Browse the repository at this point in the history

  5. use out of range service/port values across all platforms 

    Some systems treat it as unsigned internally so ULONG_MAX+1 is needed, not LONG_MAX+1.
    @gpshead
    gpshead authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2ec8318 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Rework the test to allow gaierror or no-error. 

    Also updates our canned getaddrinfo.c implementation to actually
report an error for values outside of the u_short range it casts
the value to instead of ignoring them.
    @gpshead
    gpshead committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    7328057 View commit details
    Browse the repository at this point in the history

  2. editing typo fix

    @gpshead
    gpshead committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ba80744 View commit details
    Browse the repository at this point in the history

  3. lol typo

    @gpshead
    gpshead committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5bfdda4 View commit details
    Browse the repository at this point in the history