Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43350: Don't reset active statements twice in _pysqlite_query_execute() #24681

Closed
wants to merge 3 commits into from
Closed

bpo-43350: Don't reset active statements twice in _pysqlite_query_execute() #24681

wants to merge 3 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 1, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

CI seems stuck. Re-opening to trigger it again.

@erlend-aasland erlend-aasland reopened this Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 1, 2021
@erlend-aasland erlend-aasland mentioned this pull request May 10, 2021
Closed
@gstein
Copy link

gstein commented May 10, 2021

I would suggest this be closed, in favor of #26015, which adds a (void) to the remaining reset() invocation.

@erlend-aasland
Copy link
Contributor Author

Closing this in favour of #27844.

@erlend-aasland erlend-aasland deleted the sqlite-duplicate-reset branch August 19, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting review skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @gstein @the-knights-who-say-ni @bedevere-bot