-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35134: Move non-limited C API of include/compile.h into include/cpython. #24922
Conversation
@vstinner Hi, Victor. When you plan to rewrite pyarena.h, I think this compile.h should be updated too :) But I am not sure the declaration of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work, compile.h ends with a few API which are part of the limited C API:
/* These definitions must match corresponding definitions in graminit.h. */
#define Py_single_input 256
#define Py_file_input 257
#define Py_eval_input 258
#define Py_func_type_input 345
/* This doesn't need to match anything */
#define Py_fstring_input 800
If you want to move APIs excluded from the limited C API, you need to create Include/cpython/compile.h and include it from Include/compile.h.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Misc/NEWS.d/next/C API/2021-03-19-01-26-34.bpo-35134.TMWh1i.rst
Outdated
Show resolved
Hide resolved
thanks, victor. |
https://bugs.python.org/issue35134