Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43795: PEP-652: Clean up the stable ABI/limited API #25482

Merged
merged 5 commits into from
Apr 23, 2021
Merged

bpo-43795: PEP-652: Clean up the stable ABI/limited API #25482

merged 5 commits into from
Apr 23, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented Apr 20, 2021 •
edited by bedevere-bot
Loading

  • _Py_EncodeLocaleRaw, which is private by name, undocumented,
    and wasn't exported in python3.dll, is moved to a private header.
  • _Py_HashSecret_Initialized, again private by name, undocumented,
    and not exported in python3.dll, is excluded with Py_LIMITED_API.
  • PyMarshal_* and PyMember_*One functions, declared in private headers and
    not exported in python3.dll, are removed from Doc/data/stable_abi.dat.
  • PyMem_Calloc which was exported in python3dll.c, is moved to public
    headers where it joins its other PyMem_* friends.

Only the last change is documented in the blurb; others are not user-visible.
(Nothing uses Doc/data/stable_abi.dat yet.)

https://bugs.python.org/issue43795

encukou added 5 commits April 20, 2021 14:40
@encukou
Move _Py_EncodeLocaleRaw to the private header
db837c1 
This symbol is not part of the limited API, and was even missing
in Python's stable ABI DLL.
@encukou
Don't define _Py_HashSecret_Initialized in limited API
2f05fde 
The underscore means it's not public API.
It was also not exported in the Windows stable ABI library.
@encukou
Remove PyMarshal_* and PyMember_{Get,Set}One functions from the limit…
1d11e55 
…ed API

These functions are not declared with Py_LIMITED_API.
Except for functions that take FILE*, they remain in the stable ABI.
@encukou
Include PyMem_Calloc in the limited API
75094f4
@encukou
Add blurb
2ec383f
@encukou encukou requested a review from tiran as a code owner April 20, 2021 13:21
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 20, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 2ec383f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 20, 2021
@encukou encukou mentioned this pull request Apr 20, 2021
Closed
@encukou encukou merged commit 9d6a2d0 into python:master Apr 23, 2021
@encukou encukou deleted the pep652-cleanup branch April 23, 2021 12:18
@encukou encukou mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@encukou @bedevere-bot @the-knights-who-say-ni