Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43795: Note Stable ABI PEP in What's New #26479

Merged
merged 2 commits into from
Jun 8, 2021
Merged

bpo-43795: Note Stable ABI PEP in What's New #26479

merged 2 commits into from
Jun 8, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 1, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 1, 2021
shihai1991
shihai1991 reviewed Jun 1, 2021
View reviewed changes
Doc/whatsnew/3.10.rst
PEP 652: Maintaining the Stable ABI
-----------------------------------

The Stable ABI (Application Binary Interface) for extension modules or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. The Stable ABI and C API in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the limited C API is also defined. I went with the PEP name to make things shorter.

@encukou encukou added the needs backport to 3.10 only security fixes label Jun 3, 2021
Fidget-Spinner
Fidget-Spinner approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small suggestion below.

Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
@encukou @Fidget-Spinner
Update Doc/whatsnew/3.10.rst
62b6d29 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@encukou encukou merged commit 257e400 into python:main Jun 8, 2021
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@encukou encukou deleted the pep652-document branch June 8, 2021 15:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2021
@encukou @miss-islington
bpo-43795: Note Stable ABI PEP in What's New (pythonGH-26479)
ebfeaf6 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
(cherry picked from commit 257e400)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 8, 2021
@bedevere-bot
Copy link

GH-26603 is a backport of this pull request to the 3.10 branch.

encukou pushed a commit that referenced this pull request Jun 8, 2021
@miss-islington
bpo-43795: Note Stable ABI PEP in What's New (GH-26479) (GH-26603)
7518556 
(cherry picked from commit 257e400)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@encukou encukou mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991 shihai1991 left review comments

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@encukou @miss-islington @bedevere-bot @shihai1991 @Fidget-Spinner @the-knights-who-say-ni