Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42238: Doc CI: Disable suspicious checks. #26575

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jun 7, 2021

They are slow and raise too many false positive, I'm in the slow
process to try to change this.

I've removed it from PEP 101 too to avoid the burden for RMs.

I've setup a cron to follow this closely / to avoid to forgot to monitor this closely.

https://bugs.python.org/issue42238

They are slow and raise too many false positive, I'm in the slow
process to try to change this.
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe you can document this unknown command in the devguide? For example, near:
https://devguide.python.org/documenting/#gotchas

@JulienPalard JulienPalard merged commit 227a093 into python:main Jun 8, 2021
@JulienPalard JulienPalard deleted the mdk/drop-suspicious branch June 8, 2021 07:23
@JulienPalard
Copy link
Member Author

For the moment my biggest issue is: people are autonomously and quietly fixing what's reported by make suspicious, so I don't have a list of true positives to work on.

So my current idea is to let people people commit errors¹, fix them myself (I've setup a build bot to monitor this closely) to document true positives and try to implement them in make check (or in Sphinx).

1: It is not expected to happen often, and have the nice side effet of not bothering people with false positives: 9 out of 12 errors reported by make suspicious are false positives.

@bedevere-bot
Copy link

GH-98221 is a backport of this pull request to the 3.10 branch.

JulienPalard added a commit that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants