Update programming.rst #2768
Closed
Update programming.rst #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kgashok, could you please open an issue on http://bugs.python.org/, as described in the devguide? I am not sure this is a documentation bug, because IMHO it is not clear what the example wants to emphasize. I am not a native English speaker, but the first sentence of the section seems wrong to me. We will discuss it in http://bugs.python.org/ |
terryjreedy
reviewed
Jul 24, 2017
| @@ -803,7 +803,7 @@ the same sign as ``i``. | |||
| There are few real use cases for ``i % j`` when ``j`` is negative. When ``j`` | |||
| is positive, there are many, and in virtually all of them it's more useful for | |||
| ``i % j`` to be ``>= 0``. If the clock says 10 now, what did it say 200 hours | |||
| ago? ``-190 % 12 == 2`` is useful; ``-190 % 12 == -10`` is a bug waiting to | |||
| ago? ``-190 % 12 == 2`` is useful; ``-190 % -12 == -10`` is a bug waiting to | |||
| bite. | |||
There was a problem hiding this comment.
The trivial correction is wrong, and it misses the point of the 'False' equality. If -190 % 12 were -10 instead of 2, it would be less useful and possibly lead to bugs.
|
I opened bpo-31021 to propose a correct change to what is a confusing hypothetical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing negative sign added.