-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile #29094
Conversation
This reads much better than the other one. I am convinced. I'm closing the other one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left a comment. Thanks a lot for making this PR!
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more detail than I was suggesting, but wording looks fine to me.
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
GH-29104 is a backport of this pull request to the 3.10 branch. |
GH-29105 is a backport of this pull request to the 3.9 branch. |
…ile (pythonGH-29094) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> (cherry picked from commit dff0b71) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
…ile (pythonGH-29094) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> (cherry picked from commit dff0b71) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
* main: (263 commits) bpo-45521: Fix a bug in the obmalloc radix tree code. (pythonGH-29051) bpo-45522: Allow to disable freelists on build time (pythonGH-29056) bpo-34451: Document prompt and output toggle feature in html tutorial (pythonGH-27105) bpo-44019: Add operator.call() to __all__ for the operator module (pythonGH-29110) bpo-45315: PyType_FromSpec: Copy spec->name and have the type own the memory for its name (pythonGH-29103) bpo-44220: Export PyStructSequence_UnnamedField in the limited API (pythonGH-26331) bpo-44174: [Enum] add reference to name mangling (pythonGH-29116) bpo-45548: add some missing entries to `Modules/Setup` (pythonGH-29115) bpo-35673: Add a public alias for namespace package __loader__ attribute (python#29049) bpo-45192: Fix a bug that infers the type of an os.PathLike[bytes] object as str (pythonGH-28323) bpo-45527: Don't count cache hits, just misses. (pythonGH-29092) bpo-45320: Remove long-deprecated inspect methods (pythonGH-28618) bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (pythonGH-21649) bpo-45532: Replace 'default' with 'main' as default in sys.version (pythonGH-29100) bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile (pythonGH-29094) Cleanup a couple of comments left on PR 28775 post-merge. (pythonGH-29079) bpo-45536: Check OpenSSL APIs in configure (pythonGH-29088) Add PEPs 593 & 647 to list of PEPs at top of typing docs (pythonGH-29097) Add a comment about how to fix bogus test_host_resolution_bad_address failures (python#29085) bpo-44525: Specialize simple Python calls. (pythonGH-29033) ...
This is an alternative to GH-28995 which avoids using a
warning
box, instead using the recommended affirmative tone. It also provides more details.https://bugs.python.org/issue45464