Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) #29644

Merged
merged 1 commit into from
Nov 20, 2021
Merged

bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) #29644

merged 1 commit into from
Nov 20, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 19, 2021 •
edited by bedevere-bot
Loading

@tiran tiran requested a review from ned-deily November 19, 2021 21:23
@tiran
Copy link
Member Author

tiran commented Nov 19, 2021

On macOS, the Makefile should contain:

MODULE__SCPROXY=yes
MODULE__SCPROXY_CFLAGS=
MODULE__SCPROXY_LDFLAGS=-framework SystemConfiguration -framework CoreFoundation

and setup.py should pick up the settings automatically.

ned-deily
ned-deily approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiran tiran marked this pull request as ready for review November 20, 2021 09:18
@tiran tiran changed the title bpo-45847: Port _scproxy to PY_STDLIB_MOD bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) Nov 20, 2021
@tiran tiran merged commit 5596909 into python:main Nov 20, 2021
@tiran tiran deleted the bpo-45847-scproxy branch November 20, 2021 09:18
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @remykarem
bpo-45847: Port _scproxy to PY_STDLIB_MOD (pythonGH-29644)
6de7f74
@tiran tiran mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @ned-deily @the-knights-who-say-ni @bedevere-bot