bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720) #29720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-45847-gdbm
branch
from
d418618
to
f7e0372
Compare
erlend-aasland
approved these changes
Nov 23, 2021
| [ndbm], [], | ||
| [gdbm], [have_gdbm_dbmliborder=yes], | ||
| [bdb], [], | ||
| [with_dbmliborder=error] |
There was a problem hiding this comment.
I'd just put AC_MSG_ERROR here, avoiding the AS_VAR_IF below, but I'm fine with this variant as well.
There was a problem hiding this comment.
I tried it. For unknown reasons it does not work. I get a bunch of shell error messages when the error case is triggered.
Comment on lines
+3380
to
+3381
| as_save_IFS=$IFS | ||
| IFS=: |
There was a problem hiding this comment.
BTW, why do we save IFS here? AFAICS, there's nothing touching it, but I may be mistaken.
There was a problem hiding this comment.
I'm saving and setting IFS here so the for loop uses : as a field separator.
There was a problem hiding this comment.
Yes, just found it in the man page. Learned something new today.
tiran
changed the title
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45847