Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884) #29884

Merged
merged 1 commit into from
Dec 1, 2021
Merged

bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884) #29884

merged 1 commit into from
Dec 1, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Dec 1, 2021 •
edited by bedevere-bot
Loading

@tiran
Copy link
Member Author

tiran commented Dec 1, 2021

I forgot to remove --with-ensurepip=no from the build script when I tested the first patch.

@tiran tiran requested a review from brettcannon December 1, 2021 21:04
@brettcannon
Copy link
Member

Shows how valuable my reviews are 😅

@tiran
Copy link
Member Author

tiran commented Dec 1, 2021

Shows how valuable my reviews are sweat_smile

We need CI :)

@tiran tiran changed the title bpo-40280: Emscripten with_ensurepip=no, second attempt bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884) Dec 1, 2021
@tiran tiran merged commit 309110f into python:main Dec 1, 2021
@tiran tiran deleted the bpo-40280-ensurepip2 branch December 1, 2021 22:16
@tiran tiran mentioned this pull request Dec 2, 2021
Closed
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot