Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE #30029

Closed
wants to merge 2 commits into from
Closed

gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE #30029

wants to merge 2 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 10, 2021 •
edited by bedevere-bot
Loading

AC_CHECK_TYPE is deprecated.

Removed the __uint128_t check, as the define it produced is unused.

https://bugs.python.org/issue45723

bpo-45723: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE
f6385ae 
AC_CHECK_TYPE is deprecated.

Removed the __uint128_t check, as it is unused.
@erlend-aasland erlend-aasland added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Dec 10, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f6385ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 10, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 10, 2022
MaxwellDupre
MaxwellDupre suggested changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python executable created and tests look ok, but I see in config.log:
configure:19906: checking for socklen_t configure:19906: gcc -c conftest.c >&5 configure:19906: $? = 0 configure:19906: gcc -c conftest.c >&5 conftest.c: In function 'main': conftest.c:432:24: error: expected expression before ')' token 432 | if (sizeof ((socklen_t))) |

This looks like an issue.

@erlend-aasland erlend-aasland changed the title bpo-45723: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE Apr 10, 2022
@tiran tiran mentioned this pull request Apr 22, 2022
Closed
@erlend-aasland
Copy link
Contributor Author

I don't have the bandwith to follow up this PR at the moment. Closing it for now.

@erlend-aasland erlend-aasland deleted the ac-check-types branch July 23, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre requested changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
awaiting core review skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @bedevere-bot @MaxwellDupre @the-knights-who-say-ni @ezio-melotti