Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) #30615

Merged
merged 1 commit into from
Jan 25, 2022
Merged

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) #30615

merged 1 commit into from
Jan 25, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 15, 2022 •
edited by bedevere-bot
Loading

@tiran tiran force-pushed the bpo-40280-test-subprocess branch from e61311a to 87fd2fe Compare January 16, 2022 22:03
@tiran tiran force-pushed the bpo-40280-test-subprocess branch 2 times, most recently from 61decef to 8c9097e Compare January 21, 2022 15:38
@tiran tiran force-pushed the bpo-40280-test-subprocess branch from 8c9097e to d20fdb2 Compare January 24, 2022 08:19
@tiran tiran marked this pull request as ready for review January 24, 2022 08:52
emmatyping
emmatyping approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@tiran tiran changed the title bpo-40280: Skip subprocess-based tests on wasm32-emscripten bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) Jan 25, 2022
@tiran tiran merged commit 8464fbc into python:main Jan 25, 2022
@tiran tiran deleted the bpo-40280-test-subprocess branch January 25, 2022 07:09
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@emmatyping emmatyping emmatyping approved these changes

@gpshead gpshead gpshead approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiran @gpshead @emmatyping @kumaraditya303 @the-knights-who-say-ni @bedevere-bot