Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40066: [Enum] fix doc and unit tests #30643

Merged
merged 1 commit into from
Jan 17, 2022
Merged

bpo-40066: [Enum] fix doc and unit tests #30643

merged 1 commit into from
Jan 17, 2022

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Jan 17, 2022 •
edited by bedevere-bot
Loading

  • skip doctest that changes depending on target system
  • substitute in values that change depending on target system

https://bugs.python.org/issue40066

@ethanfurman
fix tests
10372ae 
- skip doctest that changes depending on target system
- substitute in values that change depending on target system
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 17, 2022
@ethanfurman ethanfurman self-assigned this Jan 17, 2022
vstinner
vstinner approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe @kulikjak wants to test it on Solaris before it's merged?

kulikjak
kulikjak approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@kulikjak kulikjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I quickly tested those and now it works as expected.

@vstinner
Copy link
Member

@kulikjak: I quickly tested those and now it works as expected.

Cool, thanks for testing!

@ethanfurman ethanfurman merged commit 62a6594 into python:main Jan 17, 2022
@ethanfurman
Copy link
Member Author

Thanks everyone for your help.

@ethanfurman ethanfurman deleted the 40066-fix_tests branch November 23, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulikjak kulikjak kulikjak approved these changes

@vstinner vstinner vstinner approved these changes

Assignees

@ethanfurman ethanfurman

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethanfurman @vstinner @kulikjak @the-knights-who-say-ni @bedevere-bot