Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "bpo-46329: Split calls into precall and call instructions." #31011

Closed
wants to merge 2 commits into from
Closed

Revert "bpo-46329: Split calls into precall and call instructions." #31011

wants to merge 2 commits into from

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 29, 2022 •
edited by bedevere-bot
Loading

@pablogsal
Copy link
Member Author

CC: @markshannon @brandtbucher

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 29, 2022
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 29, 2022
@python python deleted a comment from bedevere-bot Jan 29, 2022
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 29, 2022
@brandtbucher
Copy link
Member

#31005 probably needs to be reverted with this as well.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d8e8cbc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 29, 2022
@pablogsal
Copy link
Member Author

#31005 probably needs to be reverted with this as well.

👍 Yep, I just pushed the commit.

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d8e8cbc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 29, 2022
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 31, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit d8e8cbc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 31, 2022
@ambv ambv force-pushed the revert-30855-split-calls-into-precall-and-call-part-2 branch from d8e8cbc to ada2b00 Compare January 31, 2022 10:56
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 31, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit ada2b00 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 31, 2022
@markshannon markshannon mentioned this pull request Jan 31, 2022
Closed
@pablogsal pablogsal closed this Feb 1, 2022
@ambv ambv deleted the revert-30855-split-calls-into-precall-and-call-part-2 branch February 2, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @brandtbucher @bedevere-bot @ambv @the-knights-who-say-ni